Skip to content

Conversation

@ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  • Right click on Tags section header in the sidebar
  • Click Manage tags

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. I used the steps described above

Future Developments
Should we add a second-level target (like a specific section of a page)?

@yaira2 yaira2 changed the title Feature: Added Manage Tags to sidebar context's menu Feature: Added an option to manage tags when right clicking on the sidebar Nov 17, 2024
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 17, 2024
@yaira2 yaira2 requested a review from 0x5bfa November 17, 2024 15:46
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first time we make use of "parameter" in Actions and I think this is the most elegant way of doing this as of now.

LGTM, code wise.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 18, 2024
@yaira2 yaira2 merged commit 5af9f59 into files-community:main Nov 18, 2024
6 checks passed
@ferrariofilippo ferrariofilippo deleted the feature_support_deep_linking branch November 18, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Ability to create tags from the Tags section and from the context menu

3 participants